esp-idf/components
Ivan Grokhotkov e15818c71b
console: fix a crash when initializing usb_serial_jtag console
The crash occurred when calling setvbuf(stdin,...) with stdin==NULL.
This happened because esp_console_repl_task started running before
its args->uart_channel was initialized; then esp_console_repl_task
went into the code path 'uart_channel != CONFIG_ESP_CONSOLE_UART_NUM',
and tried to 'fopen("/dev/uart/0");`
Since the UART VFS is not registered when ESP_CONSOLE_USB_SERIAL_JTAG
option is enabled, fopen failed and 'stdin' was NULL.
Fix by moving the initialization of repl task arguments before the
start of the task, same as it is done for the usb_cdcacm case.

The crash started happening after the commit 287ab7566b. I haven’t
verified this, but I guess the reason why it wasn’t happening before
was that xTaskCreate was not correctly yielding to the newly created
higher-priority 'repl' task, therefore the code which was setting
the repl task arguments after xTaskCreate had time to execute.

It should be noted that the 'uart_channel' argument is a bit hacky,
in the first place. The code should be refactored to pass a callback
function to the repl task, and let this callback initialize stdin and
stdout based on the chosen console channel. Then esp_console_repl_task
does not require assumptions about the specific interface used.

Closes https://github.com/espressif/esp-idf/issues/9662
2022-09-13 09:00:59 +02:00
..
app_trace build system: re-add -Wno-format as private flag for some components 2022-08-03 16:42:47 +04:00
app_update app_update: Moved app metadata to new component esp_app_format 2022-08-24 14:44:32 +05:30
bootloader bootloader: allow skip image validation on C2 2022-09-06 14:21:47 +08:00
bootloader_support bootloader_support: fix stringop-overflow warning with PERF compiler optimization 2022-09-05 13:40:22 +05:30
bt Merge branch 'bugfix/deadlock_after_call_esp_bluedroid_disable_v5.0' into 'release/v5.0' 2022-09-08 17:25:24 +08:00
cmock Build & config: Remove leftover files from the unsupported "make" build system 2021-11-11 15:32:36 +01:00
console console: fix a crash when initializing usb_serial_jtag console 2022-09-13 09:00:59 +02:00
cxx esp_hw_support: Remove compare_set.h API 2022-07-22 00:06:06 +08:00
driver Merge branch 'bugfix/fix_gpio_intr_lost_v5.0' into 'release/v5.0' 2022-09-09 15:05:50 +08:00
efuse efuse(es32c2): Supports 26MHz XTAL 2022-09-02 10:05:20 +00:00
esp_adc esp_adc: migrate adc wifi test to test app 2022-08-29 12:33:16 +08:00
esp_app_format esp_app_format: Added test-app 2022-08-24 14:46:32 +05:30
esp_common build system: re-add -Wno-format as private flag for some components 2022-08-03 16:42:47 +04:00
esp_eth build system: re-add -Wno-format as private flag for some components 2022-08-03 16:42:47 +04:00
esp_event build system: re-add -Wno-format as private flag for some components 2022-08-03 16:42:47 +04:00
esp_gdbstub coverity: fix uninit variable issue in driver 2022-08-03 10:46:50 +08:00
esp_hid build system: re-add -Wno-format as private flag for some components 2022-08-03 16:42:47 +04:00
esp_http_client build system: re-add -Wno-format as private flag for some components 2022-08-03 16:42:47 +04:00
esp_http_server build system: re-add -Wno-format as private flag for some components 2022-08-03 16:42:47 +04:00
esp_https_ota esp_app_format: Fixed build errors and resolved dependencies 2022-08-24 14:46:32 +05:30
esp_https_server esp_https_server: fix issue with default initialization through HTTPD_SSL_CONFIG_DEFAULT 2022-09-05 11:06:42 +05:30
esp_hw_support mmu: driver framework, for vaddr maintenance 2022-08-27 16:05:51 +08:00
esp_lcd rgb_lcd: deprecate esp_lcd_color_space_t 2022-08-18 10:59:16 +08:00
esp_local_ctrl build system: re-add -Wno-format as private flag for some components 2022-08-03 16:42:47 +04:00
esp_netif esp_netif: Migrate SLIP interface to user-space 2022-08-18 07:07:44 +02:00
esp_phy build system: re-add -Wno-format as private flag for some components 2022-08-03 16:42:47 +04:00
esp_pm Merge branch 'feat/support_esp32c2_uart_v5.0' into 'release/v5.0' 2022-08-25 02:03:26 +08:00
esp_psram mmu: driver framework, for vaddr maintenance 2022-08-27 16:05:51 +08:00
esp_ringbuf rename xHoldSemaphore to result 2022-08-16 10:50:37 +08:00
esp_rom esp_wifi: Remove ieee80211_crypto_aes_128_cmac_decrypt from esp32c2 rom 2022-09-07 14:58:16 +05:30
esp_serial_slave_link build system: re-add -Wno-format as private flag for some components 2022-08-03 16:42:47 +04:00
esp_system Merge branch 'bugfix/remove_remaining_rom_time_t_dependencies_v5.0' into 'release/v5.0' 2022-08-29 22:52:33 +08:00
esp_timer esp_hw_support: Fix esp_light_sleep_start() deadlock 2022-08-11 18:38:51 +08:00
esp_wifi esp_wifi: Fix the bug that espnow clear key register fail 2022-08-23 14:50:43 +08:00
esp-tls esp_tls/wpa_supplicant: Updated deprecated mbedtls APIs 2022-08-26 11:46:54 +05:30
espcoredump esp_app_format: Fixed build errors and resolved dependencies 2022-08-24 14:46:32 +05:30
esptool_py esp32h2: disable no_stub option 2022-08-08 20:44:15 +08:00
fatfs build system: re-add -Wno-format as private flag for some components 2022-08-03 16:42:47 +04:00
freertos freertos: Fix flakey event group unit tests 2022-08-12 16:48:18 +08:00
hal gpio: Fix interrupt lost issue 2022-09-08 11:52:25 +08:00
heap heap: Move the declaration of tlsf_poison_fill_pfunc_set() in esp_rom component 2022-08-15 11:11:52 +02:00
http_parser docs/en: Add entry for http_parser in copyrights page 2022-01-11 10:26:25 +05:30
idf_test freertos: fix inlining for xtensa port 2022-07-07 09:04:51 +00:00
ieee802154 openthread: update OpenThread submodule 2022-08-25 17:02:45 +08:00
json Build & config: Remove leftover files from the unsupported "make" build system 2021-11-11 15:32:36 +01:00
linux linux: add dummy sys/lock.h implementation (single threaded only) 2022-01-24 18:51:40 +01:00
log log: fix -Wformat issue when uint32_t == unsigned long 2022-08-03 16:42:47 +04:00
lwip lwip: Reference official 2.1.3-esp branch 2022-08-16 15:07:54 +02:00
mbedtls mbedtls: Override ecp_mul_restartable_internal 2022-08-26 11:46:55 +05:30
mqtt build system: re-add -Wno-format as private flag for some components 2022-08-03 16:42:47 +04:00
newlib build system: re-add -Wno-format as private flag for some components 2022-08-03 16:42:47 +04:00
nvs_flash build system: re-add -Wno-format as private flag for some components 2022-08-03 16:42:47 +04:00
openthread openthread: update OpenThread submodule 2022-08-25 17:02:45 +08:00
partition_table build system: re-add -Wno-format as private flag for some components 2022-08-03 16:42:47 +04:00
perfmon build system: re-add -Wno-format as private flag for some components 2022-08-03 16:42:47 +04:00
protobuf-c protobuf-c: Update submodule to v1.4.0 2022-05-30 09:54:31 +05:30
protocomm wifi_provisioning: Update API documentation to highlight argument validity while providing sec_params argument. 2022-09-05 12:00:55 +05:30
pthread build system: re-add -Wno-format as private flag for some components 2022-08-03 16:42:47 +04:00
riscv build system: remove -Wno-format flag for RISC-V targets 2022-08-03 16:42:47 +04:00
sdmmc build system: re-add -Wno-format as private flag for some components 2022-08-03 16:42:47 +04:00
soc mmu: driver framework, for vaddr maintenance 2022-08-27 16:05:51 +08:00
spi_flash esp_psram: rename esp_private/mmu.h to mmu_psram_flash.h 2022-08-27 15:11:15 +08:00
spiffs Tools: Fix flake8 version 5 warnings 2022-08-12 15:36:11 +02:00
tcp_transport Replaced logging tags with lower case in tcp_transport component to unite all tags under common structure. 2022-08-19 15:25:44 +02:00
tinyusb usb: Add HID device example 2022-07-27 05:31:09 +00:00
touch_element build system: re-add -Wno-format as private flag for some components 2022-08-03 16:42:47 +04:00
ulp ulp: fix -Wformat errors in ULP tests 2022-08-04 12:19:28 +08:00
unity unity_utils: added helper function to disable cache and run user function 2022-08-18 10:57:12 +08:00
usb build system: re-add -Wno-format as private flag for some components 2022-08-03 16:42:47 +04:00
vfs build system: re-add -Wno-format as private flag for some components 2022-08-03 16:42:47 +04:00
wear_levelling build system: re-add -Wno-format as private flag for some components 2022-08-03 16:42:47 +04:00
wifi_provisioning Merge branch 'feature/wifi_prov_mgr_is_provisioned_api_change_v5.0' into 'release/v5.0' 2022-09-08 12:26:36 +08:00
wpa_supplicant wpa_supplicant: remove RC4 and 3DES ciphers for TLS 2022-08-29 14:57:09 +00:00
xtensa xtensa: fix swapped breakpoint and watchpoint numbers 2022-07-25 09:43:10 +02:00
README.md esp_hw_support/esp_system: Re-evaluate header inclusions and include directories 2022-03-07 11:18:08 +05:30

Core Components

Overview

This document contains details about what the core components are, what they contain, and how they are organized.

Organization

The core components are organized into two groups.

The first group (referred to as G0 from now on) contains hal, xtensa and riscv (referred to as arch components from now on), esp_rom, esp_common, and soc. This group contain information about and low-level access to underlying hardware; or in the case of esp_common, hardware-agnostic code and utilities. These components can depend on each other, but as much as possible have no dependencies outside the group. The reason for this is that, due to the nature of what these components contain, the likelihood is high that a lot of other components will require these. Ideally, then, the dependency relationship only goes one way. This makes it easier for these components, as a group, to be usable in another project. One can conceivably implement a competing SDK to ESP-IDF on top of these components.

The second group (referred to as G1 from now on) sits at a higher level than the first group. This group contains the components esp_hw_support, esp_system, newlib, spi_flash, freertos, log, and heap. Like the first group, circular dependencies within the group are allowed; and being at a higher level, dependency on the first group is allowed. These components represent software mechanisms essential to building other components.

Descriptions

The following is a short description of the components mentioned above.

G0 Components

hal

Contains the hardware abstraction layer and low-level operation implementations for the various peripherals. The low-level functions assign meaningful names to register-level manipulations; the hardware abstraction provide operations one level above this, grouping these low-level functions into routines that achieve a meaningful action or state of the peripheral.

Example:

  • spi_flash_ll_set_address is a low-level function part of the hardware abstraction spi_flash_hal_read_block

arch

Contains low-level architecture operations and definitions, including those for customizations (can be thought of on the same level as the low-level functions of hal). This can also contain files provided by the architecture vendor.

Example:

  • xt_set_exception_handler
  • riscv_global_interrupts_enable
  • ERI_PERFMON_MAX

esp_common

Contains hardware-agnostic definitions, constants, macros, utilities, 'pure' and/or algorithmic functions that is useable by all other components (that is, barring there being a more appropriate component to put them in).

Example:

  • BIT(nr) and other bit manipulation utilities in the future
  • IDF_DEPRECATED(REASON)
  • ESP_IDF_VERSION_MAJOR

soc

Contains description of the underlying hardware: register structure, addresses, pins, capabilities, etc.

Example:

  • DR_REG_DPORT_BASE
  • SOC_MCPWM_SUPPORTED
  • uart_dev_s

esp_rom

Contains headers, linker scripts, abstraction layer, patches, and other related files to ROM functions.

Example:

  • esp32.rom.eco3.ld
  • rom/aes.h

G1 Components

spi_flash

SPI flash device access implementation.

freertos

FreeRTOS port to targets supported by ESP-IDF.

log

Logging library.

heap

Heap implementation.

newlib

Some functions n the standard library are implemented here, especially those needing other G1 components.

Example:

  • malloc is implemented in terms of the component heap's functions
  • gettimeofday is implemented in terms of system time in esp_system

esp_system

Contains implementation of system services and controls system behavior. The implementations here may take hardware resources and/or decide on a hardware state needed for support of a system service/feature/mechanism. Currently, this encompasses the following, but not limited to:

  • Startup and initialization
  • Panic and debug
  • Reset and reset reason
  • Task and interrupt watchdogs

esp_hw_support

Contains implementations that provide hardware operations, arbitration, or resource sharing, especially those that is used in the system. Unlike esp_system, implementations here do not decide on a hardware state or takes hardware resource, acting merely as facilitator to hardware access. Currently, this encompasses the following, but not limited to:

  • Interrupt allocation
  • Sleep functions
  • Memory functions (external SPIRAM, async memory, etc.)
  • Clock and clock control
  • Random generation
  • CPU utilities
  • MAC settings

esp_hw_support vs esp_system

This section details list some implementations and the reason for placing it in either esp_hw_support or esp_system.

task_wdt.c (esp_system) vs intr_alloc.c (esp_hw_support)

The task watchdog fits the definition of taking and configuring hardware resources (wdt, interrupt) for implementation of a system service/mechanism.

This is in contrast with interrupt allocation that merely facilitates access to the underlying hardware for other implementations - drivers, user code, and even the task watchdog mentioned previously!

crosscore_int.c (esp_system)

The current implementation of crosscore interrupts is tightly coupled with a number of interrupt reasons associated with system services/mechanisms: REASON_YIELD (scheduler), REASON_FREQ_SWITCH (power management) REASON_PRINT_BACKTRACE (panic and debug).

However, if an implementation exists that makes it possible to register an arbitrary interrupt reason - a lower level inter-processor call if you will, then this implementation is a good candidate for esp_hw_support. The current implementation in esp_system can then just register the interrupt reasons mentioned above.

esp_mac.h, esp_chip_info.h, esp_random.h (esp_hw_support)

The functions in these headers used to be in esp_system.h, but have been split-off.

The remaining functions in esp_system.h are those that deal with system behavior, such as esp_register_shutdown_handler, or are proxy for other system components's APIs such as esp_get_free_heap_size.

The functions split-off from esp_system.h are much more hardware manipulation oriented such as: esp_read_mac, esp_random and esp_chip_info.