mirror of
https://github.com/espressif/esp-idf.git
synced 2024-10-05 20:47:46 -04:00
6406620712
idf.py spawns gdb process within a thread and uses Thread.join() to wait for the gdb process to finish. As CTRL+C(SIGINT) is used by gdb to interrupt the running program, we catch the SIGINT while waiting on the gdb to finish, and try Thread.join() again. With cpython's commit commit a22be4943c119fecf5433d999227ff78fc2e5741 Author: Victor Stinner <vstinner@python.org> Date: Mon Sep 27 14:20:31 2021 +0200 bpo-45274: Fix Thread._wait_for_tstate_lock() race condition (GH-28532) this logic doesn't work anymore, because cpython internally marks the thread as stopped when join() is interrupted with an exception. IMHO this is broken in cpython and there is a bug report about this https://github.com/python/cpython/issues/90882. Problem is that waiting on a thread to finish is based on acquiring a lock. Meaning join() is waiting on _tstate_lock. If this wait is interrupted, the above referenced commit adds a logic that checks if the lock is help, meaning the thread is done and marks the thread as stopped. But there is no way to tell if the lock was acquired by us running join() or if it's held by someone else e.g. still by the thread bootstrap code. Meaning the thread is still running. I may be missing something, but I don't see any reason why to spawn gdb process within a thread. This change removes the thread and spawns gdb directly. Instead waiting on a thread, we wait on the process to finish, replacing join() with wait() and avoiding this problem. Closes https://github.com/espressif/esp-idf/issues/11871 Signed-off-by: Frantisek Hrbata <frantisek.hrbata@espressif.com> |
||
|---|---|---|
| .. | ||
| ble | ||
| catch | ||
| ci | ||
| cmake | ||
| docker | ||
| esp_app_trace | ||
| esp_prov | ||
| gen_soc_caps_kconfig | ||
| idf_py_actions | ||
| kconfig_new | ||
| ldgen | ||
| mass_mfg | ||
| mocks | ||
| requirements | ||
| templates/sample_component | ||
| test_apps | ||
| test_build_system | ||
| test_idf_py | ||
| test_idf_tools | ||
| test_mkdfu | ||
| test_mkuf2 | ||
| test_sbom | ||
| unit-test-app | ||
| check_python_dependencies.py | ||
| check_term.py | ||
| detect_python.fish | ||
| detect_python.sh | ||
| eclipse-code-style.xml | ||
| format-minimal.sh | ||
| format.sh | ||
| gdb_panic_server.py | ||
| gen_esp_err_to_name.py | ||
| generate_debug_prefix_map.py | ||
| idf_monitor.py | ||
| idf_size.py | ||
| idf_tools.py | ||
| idf.py | ||
| install_util.py | ||
| mkdfu.py | ||
| mkuf2.py | ||
| python_version_checker.py | ||
| requirements_schema.json | ||
| requirements.json | ||
| set-submodules-to-github.sh | ||
| split_paths_by_spaces.py | ||
| tools_schema.json | ||
| tools.json | ||