mirror of
https://github.com/espressif/esp-idf.git
synced 2024-10-05 20:47:46 -04:00
562af8f65e
This MR removes the common dependency from every IDF components to the SOC component. Currently, in the ``idf_functions.cmake`` script, we include the header path of SOC component by default for all components. But for better code organization (or maybe also benifits to the compiling speed), we may remove the dependency to SOC components for most components except the driver and kernel related components. In CMAKE, we have two kinds of header visibilities (set by include path visibility): (Assume component A --(depends on)--> B, B is the current component) 1. public (``COMPONENT_ADD_INCLUDEDIRS``): means this path is visible to other depending components (A) (visible to A and B) 2. private (``COMPONENT_PRIV_INCLUDEDIRS``): means this path is only visible to source files inside the component (visible to B only) and we have two kinds of depending ways: (Assume component A --(depends on)--> B --(depends on)--> C, B is the current component) 1. public (```COMPONENT_REQUIRES```): means B can access to public include path of C. All other components rely on you (A) will also be available for the public headers. (visible to A, B) 2. private (``COMPONENT_PRIV_REQUIRES``): means B can access to public include path of C, but don't propagate this relation to other components (A). (visible to B) 1. remove the common requirement in ``idf_functions.cmake``, this makes the SOC components invisible to all other components by default. 2. if a component (for example, DRIVER) really needs the dependency to SOC, add a private dependency to SOC for it. 3. some other components that don't really depends on the SOC may still meet some errors saying "can't find header soc/...", this is because it's depended component (DRIVER) incorrectly include the header of SOC in its public headers. Moving all this kind of #include into source files, or private headers 4. Fix the include requirements for some file which miss sufficient #include directives. (Previously they include some headers by the long long long header include link) This is a breaking change. Previous code may depends on the long include chain. You may need to include the following headers for some files after this commit: - soc/soc.h - soc/soc_memory_layout.h - driver/gpio.h - esp_sleep.h The major broken include chain includes: 1. esp_system.h no longer includes esp_sleep.h. The latter includes driver/gpio.h and driver/touch_pad.h. 2. ets_sys.h no longer includes soc/soc.h 3. freertos/portmacro.h no longer includes soc/soc_memory_layout.h some peripheral headers no longer includes their hw related headers, e.g. rom/gpio.h no longer includes soc/gpio_pins.h and soc/gpio_reg.h BREAKING CHANGE
32 lines
590 B
Makefile
32 lines
590 B
Makefile
SOURCE_FILES := \
|
|
app_update/esp_ota_eps.c \
|
|
log/log.c \
|
|
newlib/lock.c \
|
|
esp32/crc.cpp \
|
|
esp32/esp_random.c \
|
|
bootloader_support/src/bootloader_common.c
|
|
|
|
INCLUDE_DIRS := \
|
|
../include \
|
|
../private_include \
|
|
app_update/include \
|
|
driver/include \
|
|
esp32/include \
|
|
freertos/include \
|
|
log/include \
|
|
newlib/include \
|
|
sdmmc/include \
|
|
vfs/include \
|
|
$(addprefix ../../../../components/, \
|
|
esp_common/include \
|
|
soc/esp32/include \
|
|
soc/include \
|
|
xtensa/include \
|
|
xtensa/esp32/include \
|
|
esp32/include \
|
|
bootloader_support/include \
|
|
app_update/include \
|
|
spi_flash/include \
|
|
)
|
|
|