alex/esp-idf
alex/esp-idf
1
0
Fork 0
mirror of https://github.com/espressif/esp-idf.git synced 2024-10-05 20:47:46 -04:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

esp_https_ota: Add check for 303 and 308 status code

Browse Source 
Closes https://github.com/espressif/esp-idf/issues/8581
This commit is contained in:
Shubham Kulkarni 2022-03-17 13:50:30 +05:30 committed by BOT
parent ec6f222625
commit d5a8a57686
1 changed files with 18 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
components/esp_https_ota/src/esp_https_ota.c
View File

@ -51,12 +51,29 @@ struct esp_https_ota_handle {
typedef struct esp_https_ota_handle esp_https_ota_t; typedef struct esp_https_ota_handle esp_https_ota_t;
static bool redirection_required(int status_code)
{
switch (status_code) {
case HttpStatus_MovedPermanently:
case HttpStatus_Found:
case HttpStatus_SeeOther:
case HttpStatus_TemporaryRedirect:
case HttpStatus_PermanentRedirect:
return true;
default:
return false;
}
return false;
}
static bool process_again(int status_code) static bool process_again(int status_code)
{ {
switch (status_code) { switch (status_code) {
case HttpStatus_MovedPermanently: case HttpStatus_MovedPermanently:
case HttpStatus_Found: case HttpStatus_Found:
case HttpStatus_SeeOther:
case HttpStatus_TemporaryRedirect: case HttpStatus_TemporaryRedirect:
case HttpStatus_PermanentRedirect:
case HttpStatus_Unauthorized: case HttpStatus_Unauthorized:
return true; return true;
default: default:
@ -68,7 +85,7 @@ static bool process_again(int status_code)
static esp_err_t _http_handle_response_code(esp_http_client_handle_t http_client, int status_code) static esp_err_t _http_handle_response_code(esp_http_client_handle_t http_client, int status_code)
{ {
esp_err_t err; esp_err_t err;
if (status_code == HttpStatus_MovedPermanently || status_code == HttpStatus_Found || status_code == HttpStatus_TemporaryRedirect) { if (redirection_required(status_code)) {
err = esp_http_client_set_redirection(http_client); err = esp_http_client_set_redirection(http_client);
if (err != ESP_OK) { if (err != ESP_OK) {
ESP_LOGE(TAG, "URL redirection Failed"); ESP_LOGE(TAG, "URL redirection Failed");