alex/esp-idf
alex/esp-idf
1
0
Fork 0
mirror of https://github.com/espressif/esp-idf.git synced 2024-09-20 00:36:01 -04:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

[cxx]: Added virtual desctructor in I2C class

Browse Source 
Closes https://github.com/espressif/esp-idf/issues/7435
This commit is contained in:
Jakob Hasse 2021-10-09 12:03:00 +08:00
parent 76a44106aa
commit d023036be9
2 changed files with 6 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
examples/cxx/experimental/experimental_cpp_component/include/i2c_cxx.hpp
View File

@ -1,16 +1,8 @@
// Copyright 2020 Espressif Systems (Shanghai) PTE LTD /*
// * SPDX-FileCopyrightText: 2020-2021 Espressif Systems (Shanghai) CO LTD
// Licensed under the Apache License, Version 2.0 (the "License"); *
// you may not use this file except in compliance with the License. * SPDX-License-Identifier: Apache-2.0
// You may obtain a copy of the License at */
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
#pragma once #pragma once
@ -419,6 +411,7 @@ protected:
private: private:
class CompTransferNode { class CompTransferNode {
public: public:
virtual ~CompTransferNode() { }
virtual void queue_cmd(i2c_cmd_handle_t handle, uint8_t i2c_addr) = 0; virtual void queue_cmd(i2c_cmd_handle_t handle, uint8_t i2c_addr) = 0;
virtual void process_result(std::vector<std::vector<uint8_t> > &read_results) { } virtual void process_result(std::vector<std::vector<uint8_t> > &read_results) { }
}; };

1
tools/ci/check_copyright_ignore.txt
View File

@ -3559,7 +3559,6 @@ examples/cxx/experimental/experimental_cpp_component/include/esp_event_api.hpp
examples/cxx/experimental/experimental_cpp_component/include/esp_event_cxx.hpp examples/cxx/experimental/experimental_cpp_component/include/esp_event_cxx.hpp
examples/cxx/experimental/experimental_cpp_component/include/esp_exception.hpp examples/cxx/experimental/experimental_cpp_component/include/esp_exception.hpp
examples/cxx/experimental/experimental_cpp_component/include/esp_timer_cxx.hpp examples/cxx/experimental/experimental_cpp_component/include/esp_timer_cxx.hpp
examples/cxx/experimental/experimental_cpp_component/include/i2c_cxx.hpp
examples/cxx/experimental/experimental_cpp_component/test/test_cxx_exceptions.cpp examples/cxx/experimental/experimental_cpp_component/test/test_cxx_exceptions.cpp
examples/cxx/experimental/experimental_cpp_component/test/test_esp_event_cxx.cpp examples/cxx/experimental/experimental_cpp_component/test/test_esp_event_cxx.cpp
examples/cxx/experimental/experimental_cpp_component/test/test_esp_timer.cpp examples/cxx/experimental/experimental_cpp_component/test/test_esp_timer.cpp