mirror of
https://github.com/espressif/esp-idf.git
synced 2024-10-05 20:47:46 -04:00
fix(idf_tools): execution of empty command in get_version()
The ticket below reports some very strange behaviour, where even a simple command like the following python3 -c "import subprocess; subprocess.run([''])" actually spawns some process and pass instead of raising PermissionError. Even though the problem is most probably somewhere else, not in idf_tools, we may just return early if there is no command available for get_version(). Closes https://github.com/espressif/esp-idf/issues/11880 Signed-off-by: Frantisek Hrbata <frantisek.hrbata@espressif.com>
This commit is contained in:
parent
c9282e7dab
commit
bf1a487b73
@ -689,6 +689,13 @@ class IDFTool(object):
|
||||
cmd = self._current_options.version_cmd # type: ignore
|
||||
if executable_path:
|
||||
cmd[0] = executable_path
|
||||
|
||||
if not cmd[0]:
|
||||
# There is no command available, so return early. It seems that
|
||||
# within some very strange context empty [''] may actually execute
|
||||
# something https://github.com/espressif/esp-idf/issues/11880
|
||||
raise ToolNotFound('Tool {} not found'.format(self.name))
|
||||
|
||||
try:
|
||||
version_cmd_result = run_cmd_check_output(cmd, None, extra_paths)
|
||||
except OSError:
|
||||
|
Loading…
Reference in New Issue
Block a user