alex/esp-idf
alex/esp-idf
1
0
Fork 0
mirror of https://github.com/espressif/esp-idf.git synced 2024-10-05 20:47:46 -04:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

[Heap Trace Standalone] speed up sequential access

Browse Source
This commit is contained in:
Chip Weinberger 2023-01-13 12:33:43 -08:00 committed by Guillaume Souchere
parent 26a5117870
commit a555563558
1 changed files with 32 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

45
components/heap/heap_trace_standalone.c
View File

@ -41,10 +41,10 @@ typedef struct {
/* Linked list of available record objects */ /* Linked list of available record objects */
heap_trace_record_list_t unused; heap_trace_record_list_t unused;
/* capacity of the buffer */ /* capacity of 'buffer' */
size_t capacity; size_t capacity;
/* Count of entries logged in the buffer. */ /* Count of entries in 'list' */
size_t count; size_t count;
/* During execution, we remember the maximum /* During execution, we remember the maximum
@ -74,6 +74,10 @@ static size_t total_allocations;
/* Actual number of frees logged */ /* Actual number of frees logged */
static size_t total_frees; static size_t total_frees;
/* Used to speed up heap_trace_get */
static heap_trace_record_t* rGet;
static size_t rGetIdx;
esp_err_t heap_trace_init_standalone(heap_trace_record_t *record_buffer, size_t num_records) esp_err_t heap_trace_init_standalone(heap_trace_record_t *record_buffer, size_t num_records)
{ {
if (tracing) { if (tracing) {
@ -160,24 +164,39 @@ esp_err_t heap_trace_get(size_t index, heap_trace_record_t *rOut)
} else { } else {
// Iterate through through the linked list // Perf: speed up sequential access
if (rGet && rGetIdx == index - 1) {
heap_trace_record_t* rCur = TAILQ_FIRST(&records.list); rGet = TAILQ_NEXT(rGet, tailq);
rGetIdx = index;
for (int i = 0; i < index; i++) { } else {
// this should not happen, since we already // Iterate through through the linked list
// checked that index >= records.count == false
if (rCur == NULL) { rGet = TAILQ_FIRST(&records.list);
result = ESP_ERR_INVALID_STATE;
break; for (int i = 0; i < index; i++) {
if (rGet == NULL) {
break;
}
rGet = TAILQ_NEXT(rGet, tailq);
rGetIdx = i + 1;
} }
rCur = TAILQ_NEXT(rCur, tailq);
} }
// copy to destination // copy to destination
memcpy(rOut, rCur, sizeof(heap_trace_record_t)); if (rGet) {
memcpy(rOut, rGet, sizeof(heap_trace_record_t));
} else {
// this should not happen since we already
// checked that index < records.count,
// but could be indicative of memory corruption
result = ESP_ERR_INVALID_STATE;
memset(rOut, 0, sizeof(heap_trace_record_t));
}
} }
portEXIT_CRITICAL(&trace_mux); portEXIT_CRITICAL(&trace_mux);