alex/esp-idf
alex/esp-idf
1
0
Fork 0
mirror of https://github.com/espressif/esp-idf.git synced 2024-10-05 20:47:46 -04:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

pppos client: modem netif fix ignoring potential modem-start error

Browse Source 
esp-modem netif glue layer implements esp-netif attach callback to setup corresponding driver functions and start the modem. The error code of esp_modem_start_ppp() was ignored and ESP_OK returned in all cases. Fixed by passing esp_modem_start_ppp()'s error code to post_attach callback.

Closes https://github.com/espressif/esp-idf/issues/5430
This commit is contained in:
David Cermak 2020-06-18 16:20:47 +02:00
parent f3ff3b3073
commit 99cb5a7c8d
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
examples/protocols/pppos_client/components/modem/src/esp_modem_netif.c
View File

@ -53,7 +53,7 @@ static esp_err_t esp_modem_dte_transmit(void *h, void *buffer, size_t len)
* @param esp_netif handle to esp-netif object * @param esp_netif handle to esp-netif object
* @param args pointer to modem-netif driver * @param args pointer to modem-netif driver
* *
* @return ESP_OK on success * @return ESP_OK on success, modem-start error code if starting failed
*/ */
static esp_err_t esp_modem_post_attach_start(esp_netif_t * esp_netif, void * args) static esp_err_t esp_modem_post_attach_start(esp_netif_t * esp_netif, void * args)
{ {
@ -66,8 +66,7 @@ static esp_err_t esp_modem_post_attach_start(esp_netif_t * esp_netif, void * arg
}; };
driver->base.netif = esp_netif; driver->base.netif = esp_netif;
ESP_ERROR_CHECK(esp_netif_set_driver_config(esp_netif, &driver_ifconfig)); ESP_ERROR_CHECK(esp_netif_set_driver_config(esp_netif, &driver_ifconfig));
esp_modem_start_ppp(dte); return esp_modem_start_ppp(dte);
return ESP_OK;
} }
/** /**