From b168ba98ae48ec117b914857f4cc47c2a89cb674 Mon Sep 17 00:00:00 2001 From: Mahavir Jain Date: Wed, 9 Nov 2022 15:22:14 +0530 Subject: [PATCH] esp_ds: remove requirement of aligned and DMA capable buffer API `esp_ds_encrypt_params` do not require aligned and DMA capable output buffer for C3/S3/H2/C6. Implementation in ROM code has been updated to remove usage of DMA mode. This commit updates the API documentation. --- components/esp_hw_support/include/soc/esp32c3/esp_ds.h | 2 -- components/esp_hw_support/include/soc/esp32c6/esp_ds.h | 2 -- components/esp_hw_support/include/soc/esp32h2/esp_ds.h | 2 -- components/esp_hw_support/include/soc/esp32s3/esp_ds.h | 2 -- 4 files changed, 8 deletions(-) diff --git a/components/esp_hw_support/include/soc/esp32c3/esp_ds.h b/components/esp_hw_support/include/soc/esp32c3/esp_ds.h index 4859aea1f7..0ba08d2a36 100644 --- a/components/esp_hw_support/include/soc/esp32c3/esp_ds.h +++ b/components/esp_hw_support/include/soc/esp32c3/esp_ds.h @@ -191,8 +191,6 @@ esp_err_t esp_ds_finish_sign(void *signature, esp_ds_context_t *esp_ds_ctx); * device. * * @param data Output buffer to store encrypted data, suitable for later use generating signatures. - * The allocated memory must be in internal memory and word aligned since it's filled by DMA. Both is asserted - * at run time. * @param iv Pointer to 16 byte IV buffer, will be copied into 'data'. Should be randomly generated bytes each time. * @param p_data Pointer to input plaintext key data. The expectation is this data will be deleted after this process * is done and 'data' is stored. diff --git a/components/esp_hw_support/include/soc/esp32c6/esp_ds.h b/components/esp_hw_support/include/soc/esp32c6/esp_ds.h index 70203f0700..5ab5b1bd5f 100644 --- a/components/esp_hw_support/include/soc/esp32c6/esp_ds.h +++ b/components/esp_hw_support/include/soc/esp32c6/esp_ds.h @@ -191,8 +191,6 @@ esp_err_t esp_ds_finish_sign(void *signature, esp_ds_context_t *esp_ds_ctx); * device. * * @param data Output buffer to store encrypted data, suitable for later use generating signatures. - * The allocated memory must be in internal memory and word aligned since it's filled by DMA. Both is asserted - * at run time. * @param iv Pointer to 16 byte IV buffer, will be copied into 'data'. Should be randomly generated bytes each time. * @param p_data Pointer to input plaintext key data. The expectation is this data will be deleted after this process * is done and 'data' is stored. diff --git a/components/esp_hw_support/include/soc/esp32h2/esp_ds.h b/components/esp_hw_support/include/soc/esp32h2/esp_ds.h index 9ebaf35922..1bc86e4514 100644 --- a/components/esp_hw_support/include/soc/esp32h2/esp_ds.h +++ b/components/esp_hw_support/include/soc/esp32h2/esp_ds.h @@ -193,8 +193,6 @@ esp_err_t esp_ds_finish_sign(void *signature, esp_ds_context_t *esp_ds_ctx); * device. * * @param data Output buffer to store encrypted data, suitable for later use generating signatures. - * The allocated memory must be in internal memory and word aligned since it's filled by DMA. Both is asserted - * at run time. * @param iv Pointer to 16 byte IV buffer, will be copied into 'data'. Should be randomly generated bytes each time. * @param p_data Pointer to input plaintext key data. The expectation is this data will be deleted after this process * is done and 'data' is stored. diff --git a/components/esp_hw_support/include/soc/esp32s3/esp_ds.h b/components/esp_hw_support/include/soc/esp32s3/esp_ds.h index d2dc259c43..27aa3b1c8b 100644 --- a/components/esp_hw_support/include/soc/esp32s3/esp_ds.h +++ b/components/esp_hw_support/include/soc/esp32s3/esp_ds.h @@ -175,8 +175,6 @@ esp_err_t esp_ds_finish_sign(void *signature, esp_ds_context_t *esp_ds_ctx); * Encrypt the private key parameters. * * @param data Output buffer to store encrypted data, suitable for later use generating signatures. - * The allocated memory must be in internal memory and word aligned since it's filled by DMA. Both is asserted - * at run time. * @param iv Pointer to 16 byte IV buffer, will be copied into 'data'. Should be randomly generated bytes each time. * @param p_data Pointer to input plaintext key data. The expectation is this data will be deleted after this process * is done and 'data' is stored.