alex/esp-idf
alex/esp-idf
1
0
Fork 0
mirror of https://github.com/espressif/esp-idf.git synced 2024-10-05 20:47:46 -04:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

fix: component manager load all component dirs even set(COMPONENTS ...)

Browse Source
This commit is contained in:
Fu Hanxi 2024-01-30 14:56:58 +01:00
parent d2542dd5c5
commit 74843a442b
3 changed files with 40 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
tools/cmake/build.cmake
View File

@ -516,9 +516,17 @@ macro(idf_build_process target)
set(local_components_list_file ${build_dir}/local_components_list.temp.yml)
set(__contents "components:\n")
foreach(__component_name ${components})
idf_component_get_property(__component_dir ${__component_name} COMPONENT_DIR)
idf_build_get_property(build_component_targets BUILD_COMPONENT_TARGETS)
foreach(__build_component_target ${build_component_targets})
__component_get_property(__component_name ${__build_component_target} COMPONENT_NAME)
__component_get_property(__component_dir ${__build_component_target} COMPONENT_DIR)
# Exclude components could be passed with -DEXCLUDE_COMPONENTS
# after the call to __component_add finished in the last run.
# Need to check if the component is excluded again
if(NOT __component_name IN_LIST EXCLUDE_COMPONENTS)
set(__contents "${__contents} - name: \"${__component_name}\"\n path: \"${__component_dir}\"\n")
endif()
endforeach()
file(WRITE ${local_components_list_file} "${__contents}")

3
tools/cmake/component.cmake
View File

@ -192,8 +192,9 @@ function(__component_add component_dir prefix)
# Set Kconfig related properties on the component
__kconfig_component_init(${component_target})
# set BUILD_COMPONENT_DIRS build property
# these two properties are used to keep track of the components known to the build system
idf_build_set_property(BUILD_COMPONENT_DIRS ${component_dir} APPEND)
idf_build_set_property(BUILD_COMPONENT_TARGETS ${component_target} APPEND)
endfunction()
#

28
tools/test_build_system/test_component_manager.py
View File

@ -1,9 +1,10 @@
# SPDX-FileCopyrightText: 2022 Espressif Systems (Shanghai) CO LTD
# SPDX-FileCopyrightText: 2022-2024 Espressif Systems (Shanghai) CO LTD
# SPDX-License-Identifier: Apache-2.0
import os.path
from pathlib import Path
from test_build_system_helpers import IdfPyFunc
from test_build_system_helpers import replace_in_file
def test_dependency_lock(idf_py: IdfPyFunc, test_app_copy: Path) -> None:
@ -18,3 +19,28 @@ def test_dependency_lock(idf_py: IdfPyFunc, test_app_copy: Path) -> None:
idf_py('reconfigure')
assert os.path.isfile(test_app_copy / 'dependencies.lock.esp32')
assert not os.path.isfile(test_app_copy / 'dependencies.lock')
def test_trimmed_components_still_passed_to_cmake(idf_py: IdfPyFunc, test_app_copy: Path) -> None:
replace_in_file(
test_app_copy / 'CMakeLists.txt',
search='# placeholder_after_include_project_cmake',
replace='set(COMPONENTS main)',
)
replace_in_file(
test_app_copy / 'main' / 'CMakeLists.txt',
search='# placeholder_inside_idf_component_register',
replace='REQUIRES foo',
)
os.makedirs(test_app_copy / 'components')
idf_py('create-component', '-C', 'components', 'foo')
idf_py('add-dependency', '--component', 'foo', 'example/cmp')
idf_py('reconfigure')
with open('dependencies.lock', 'r') as f:
fs = f.read()
assert ' example/cmp:' in fs