alex/esp-idf
alex/esp-idf
1
0
Fork 0
mirror of https://github.com/espressif/esp-idf.git synced 2024-10-05 20:47:46 -04:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Merge branch 'bugfix/http_client_test_memcorupt_v3.3' into 'release/v3.3'

Browse Source 
ci/test: Fix esp_http_client test not to use pointer after free (v3.3)

See merge request espressif/esp-idf!13706
This commit is contained in:
Mahavir Jain 2021-06-23 14:11:50 +00:00
commit 557525eeb9
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
components/esp_http_client/test/test_http_client.c
View File

@ -124,7 +124,10 @@ TEST_CASE("Username and password will not reset if new absolute URL doesnot spec
TEST_ASSERT_EQUAL_STRING(USERNAME, value);
esp_http_client_set_url(client, "http://" HOST "/get");
esp_http_client_set_username(client, value);
esp_http_client_set_password(client, value);
// esp_http_client_set_username sets new username and thus invalidates the original one
// which we still reference in the local variable `value` (better forget it)
value = NULL;
esp_http_client_set_password(client, (char *)USERNAME); // Need to cast the string literal (argument is not a const char*)
//checks if username is set or not
r = esp_http_client_get_username(client, &value);
TEST_ASSERT_EQUAL(ESP_OK, r);