From acdadebfff2d8cd342d9dd0da2ce8acc10b3d938 Mon Sep 17 00:00:00 2001 From: David Cermak Date: Tue, 21 Apr 2020 16:40:31 +0200 Subject: [PATCH] esp-netif: ppp netif to use netif_is_link_up() to update interface state Closes https://github.com/espressif/esp-idf/issues/5069 --- components/esp_netif/lwip/esp_netif_lwip.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/components/esp_netif/lwip/esp_netif_lwip.c b/components/esp_netif/lwip/esp_netif_lwip.c index bd6a201f82..6849021834 100644 --- a/components/esp_netif/lwip/esp_netif_lwip.c +++ b/components/esp_netif/lwip/esp_netif_lwip.c @@ -1161,8 +1161,13 @@ bool esp_netif_is_netif_up(esp_netif_t *esp_netif) { ESP_LOGV(TAG, "%s esp_netif:%p", __func__, esp_netif); - if (esp_netif != NULL && esp_netif->lwip_netif != NULL && netif_is_up(esp_netif->lwip_netif)) { - return true; + if (esp_netif != NULL && esp_netif->lwip_netif != NULL) { + if (esp_netif->is_ppp_netif) { + // ppp implementation uses netif_set_link_up/down to update link state + return netif_is_link_up(esp_netif->lwip_netif); + } + // esp-netif handlers and drivers take care to set_netif_up/down on link state update + return netif_is_up(esp_netif->lwip_netif); } else { return false; }