From 132135519da537f5446f90cce6b75bf18d8404e8 Mon Sep 17 00:00:00 2001 From: David Cermak Date: Wed, 27 Mar 2024 16:50:24 +0100 Subject: [PATCH] fix(wifi): Remove optional dependency on esp_wifi_remote if !ESP_WIFI_ENABLED The dependency could be introduced from dependent component if needed. The else() part of the condition wasn't correct, as it didn't check for esp_wifi_remote from component manager, which is prefixed by Espressif namespace, so the correct statement would be: if(espressif__esp_wifi_remote IN_LIST build_components) --- components/esp_wifi/CMakeLists.txt | 7 ------- 1 file changed, 7 deletions(-) diff --git a/components/esp_wifi/CMakeLists.txt b/components/esp_wifi/CMakeLists.txt index 61321761e1..3844ab83ed 100644 --- a/components/esp_wifi/CMakeLists.txt +++ b/components/esp_wifi/CMakeLists.txt @@ -77,13 +77,6 @@ if(CONFIG_ESP_WIFI_ENABLED) target_link_libraries(${COMPONENT_LIB} PUBLIC ${blob}) endforeach() endif() -else() - # No local wifi: use esp_wifi_remote if it's available within our components - idf_build_get_property(build_components BUILD_COMPONENTS) - if(esp_wifi_remote IN_LIST build_components) - idf_component_get_property(esp_wifi_remote esp_wifi_remote COMPONENT_LIB) - target_link_libraries(${COMPONENT_LIB} PUBLIC ${esp_wifi_remote}) - endif() endif() if(CONFIG_SPIRAM)