From 50d7e4e41cfa3814663112f1f1b4cde03f83442f Mon Sep 17 00:00:00 2001 From: kevlarh <81698238+kevlarh@users.noreply.github.com> Date: Wed, 17 Apr 2024 06:25:00 +0100 Subject: [PATCH 1/3] Eliminate compiler warning about 'BIT' macro Add parentheses to comply with compiler suggestion --- components/hal/esp32/include/hal/gpio_ll.h | 4 ++-- installation_notes.txt | 10 ++++++++++ 2 files changed, 12 insertions(+), 2 deletions(-) create mode 100644 installation_notes.txt diff --git a/components/hal/esp32/include/hal/gpio_ll.h b/components/hal/esp32/include/hal/gpio_ll.h index 20833e1ddb..d35529731e 100644 --- a/components/hal/esp32/include/hal/gpio_ll.h +++ b/components/hal/esp32/include/hal/gpio_ll.h @@ -643,9 +643,9 @@ static inline bool gpio_ll_is_digital_io_hold(gpio_dev_t *hw, uint32_t gpio_num) case 1: mask = BIT(1); break; case 3: mask = BIT(0); break; case 5: mask = BIT(8); break; - case 6 ... 11 : mask = BIT(gpio_num - 4); break; + case 6 ... 11 : mask = BIT((gpio_num - 4)); break; case 16 ... 19: - case 21 ... 23: mask = BIT(gpio_num - 7); break; + case 21 ... 23: mask = BIT((gpio_num - 7)); break; default: break; } diff --git a/installation_notes.txt b/installation_notes.txt new file mode 100644 index 0000000000..a7801f2e6b --- /dev/null +++ b/installation_notes.txt @@ -0,0 +1,10 @@ +https://github.com/espressif/binutils-gdb/releases/download/esp-gdb-v12.1_20221002/xtensa-esp-elf-gdb-12.1_20221002-x86_64-linux-gnu.tar.gz +https://github.com/espressif/binutils-gdb/releases/download/esp-gdb-v12.1_20221002/riscv32-esp-elf-gdb-12.1_20221002-x86_64-linux-gnu.tar.gz +https://github.com/espressif/crosstool-NG/releases/download/esp-12.2.0_20230208/xtensa-esp32-elf-12.2.0_20230208-x86_64-linux-gnu.tar.xz + +downloaded into: + +/home/kevin/.espressif/dist/xtensa... +/home/kevin/.espressif/dist/riscv32... + + From 93e9873b69a39ef024f79fcbdafd0de82251e880 Mon Sep 17 00:00:00 2001 From: kevlarh <81698238+kevlarh@users.noreply.github.com> Date: Wed, 17 Apr 2024 20:14:40 +0100 Subject: [PATCH 2/3] Revert "Eliminate compiler warning about 'BIT' macro" This reverts commit 50d7e4e41cfa3814663112f1f1b4cde03f83442f. --- components/hal/esp32/include/hal/gpio_ll.h | 4 ++-- installation_notes.txt | 10 ---------- 2 files changed, 2 insertions(+), 12 deletions(-) delete mode 100644 installation_notes.txt diff --git a/components/hal/esp32/include/hal/gpio_ll.h b/components/hal/esp32/include/hal/gpio_ll.h index d35529731e..20833e1ddb 100644 --- a/components/hal/esp32/include/hal/gpio_ll.h +++ b/components/hal/esp32/include/hal/gpio_ll.h @@ -643,9 +643,9 @@ static inline bool gpio_ll_is_digital_io_hold(gpio_dev_t *hw, uint32_t gpio_num) case 1: mask = BIT(1); break; case 3: mask = BIT(0); break; case 5: mask = BIT(8); break; - case 6 ... 11 : mask = BIT((gpio_num - 4)); break; + case 6 ... 11 : mask = BIT(gpio_num - 4); break; case 16 ... 19: - case 21 ... 23: mask = BIT((gpio_num - 7)); break; + case 21 ... 23: mask = BIT(gpio_num - 7); break; default: break; } diff --git a/installation_notes.txt b/installation_notes.txt deleted file mode 100644 index a7801f2e6b..0000000000 --- a/installation_notes.txt +++ /dev/null @@ -1,10 +0,0 @@ -https://github.com/espressif/binutils-gdb/releases/download/esp-gdb-v12.1_20221002/xtensa-esp-elf-gdb-12.1_20221002-x86_64-linux-gnu.tar.gz -https://github.com/espressif/binutils-gdb/releases/download/esp-gdb-v12.1_20221002/riscv32-esp-elf-gdb-12.1_20221002-x86_64-linux-gnu.tar.gz -https://github.com/espressif/crosstool-NG/releases/download/esp-12.2.0_20230208/xtensa-esp32-elf-12.2.0_20230208-x86_64-linux-gnu.tar.xz - -downloaded into: - -/home/kevin/.espressif/dist/xtensa... -/home/kevin/.espressif/dist/riscv32... - - From d524038de7e0286f60fde7b2928465b64e5eb0d6 Mon Sep 17 00:00:00 2001 From: kevlarh <81698238+kevlarh@users.noreply.github.com> Date: Wed, 17 Apr 2024 20:25:23 +0100 Subject: [PATCH 3/3] Eliminate compiler warning about 'BIT' macro Add parentheses to comply with compiler suggestion --- components/hal/esp32/include/hal/gpio_ll.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/components/hal/esp32/include/hal/gpio_ll.h b/components/hal/esp32/include/hal/gpio_ll.h index 20833e1ddb..d35529731e 100644 --- a/components/hal/esp32/include/hal/gpio_ll.h +++ b/components/hal/esp32/include/hal/gpio_ll.h @@ -643,9 +643,9 @@ static inline bool gpio_ll_is_digital_io_hold(gpio_dev_t *hw, uint32_t gpio_num) case 1: mask = BIT(1); break; case 3: mask = BIT(0); break; case 5: mask = BIT(8); break; - case 6 ... 11 : mask = BIT(gpio_num - 4); break; + case 6 ... 11 : mask = BIT((gpio_num - 4)); break; case 16 ... 19: - case 21 ... 23: mask = BIT(gpio_num - 7); break; + case 21 ... 23: mask = BIT((gpio_num - 7)); break; default: break; }